Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts ......................................................................
Patch Set 16: (1 comment) After fighting the compiler for over an hour to figure out why our operator<< was not being called, I found this little gem in glog/logging.h and since abandoned getting DCHECK_EQ / GT to work. / Build the error message string. template<class t1, class t2> std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { // It means that we cannot use stl_logging if compiler doesn't // support using expression for operator. // TODO(hamaji): Figure out a way to fix. #if 1 using ::operator<<; #endif std::strstream ss; ss << names << " (" << v1 << " vs. " << v2 << ")"; return new std::string(ss.str(), ss.pcount()); } http://gerrit.cloudera.org:8080/#/c/5951/16//COMMIT_MSG Commit Message: Line 64: Query: select sum(cast(l_extendedprice as bigint)) from > please pare down the commit msg, in particular get rid of the verbatim shel Done -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes