Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test ......................................................................
Patch Set 2: (3 comments) I'm folding this into the cast change anyway. http://gerrit.cloudera.org:8080/#/c/6068/1//COMMIT_MSG Commit Message: Line 22: > I think this probably should be fixed in this commit. This was a real problem, found it. http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 1397: true > Sorry, I may be missing something. Why is this NULL ? I am missing something too... was the test broken before? Line 1635: TestIsNotNull(c.expr, type); I added this because I noticed the non-NULL test cases were passing even when the value happened to match, which was the case for some zero values. Looks like something is broken with modulus. -- To view, visit http://gerrit.cloudera.org:8080/6068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
