Michael Ho has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts ......................................................................
Patch Set 22: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/22/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: PS22, Line 54: UNLIKELY(std::isnan(d)) || UNLIKELY(std::fabs(d) >= max_value)) nit: UNLIKELY(std::isnan(d) || std::fabs(d) >= max_value)) -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 22 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
