Michael Ho has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6107/1/be/src/exec/read-write-util.h File be/src/exec/read-write-util.h: PS1, Line 219: if (val & 0xFF00000000000000llu) return 9; : if (val & 0x00FF000000000000llu) return 8; : if (val & 0x0000FF0000000000llu) return 7; : if (val & 0x000000FF00000000llu) return 6; : if (val & 0x00000000FF000000llu) return 5; : if (val & 0x0000000000FF0000llu) return 4; : if (val & 0x000000000000FF00llu) return 3; > Why not do a bit-scan for first set bit and divide the result by 8 ? Typo. I meant bit scan from the MSB. __builtin_clzl() -- To view, visit http://gerrit.cloudera.org:8080/6107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
