Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 40 > Does that mean that severities that get mapped to VLOG will always get prin Yes, Interestingly that has always been the behavior (even without this patch because --v=1 is the default). We have the following mapping that we use to translate. I'm not totally sure what the rationale is behind this mapping. private TLogLevel levelToSeverity(Level level) { Preconditions.checkState(!level.equals(Level.OFF)); // TODO: Level does not work well in a HashMap or switch statement due to some // strangeness with equality testing. if (level.equals(Level.TRACE)) return TLogLevel.VLOG_3; if (level.equals(Level.ALL)) return TLogLevel.VLOG_3; if (level.equals(Level.DEBUG)) return TLogLevel.VLOG; if (level.equals(Level.ERROR)) return TLogLevel.ERROR; if (level.equals(Level.FATAL)) return TLogLevel.FATAL; if (level.equals(Level.INFO)) return TLogLevel.INFO; if (level.equals(Level.WARN)) return TLogLevel.WARN; throw new IllegalStateException("Unknown log level: " + level.toString()); } -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
