Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs ......................................................................
Patch Set 3: (1 comment) A couple of notes on the latest review: - It has not been tested for performance. That testing will determine the value of 'SORT_MATERIALIZATION_COST_THRESHOLD' - I'm not super happy with the functional testing, but I'm having a hard time coming up with good tests. - It doesn't include a query option, as I started looking into it and I think its going to be complicated, so I figured I would submit a follow up patch for it. There's also some design decisions here, which I've laid out in the design doc. http://gerrit.cloudera.org:8080/#/c/5914/2/fe/src/main/java/org/apache/impala/analysis/SortInfo.java File fe/src/main/java/org/apache/impala/analysis/SortInfo.java: Line 173: * result expressions. Those slot refs in the ordering and result exprs are substituted > It's important to update this smap according to the new materialization you Done -- To view, visit http://gerrit.cloudera.org:8080/5914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dcda32fc7770d42fc500ce87fc54d58e5b5dc00 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
