Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera ......................................................................
Patch Set 3: (6 comments) Ambreen, I addressed your comment about the audience=Cloudera in impala_common.xml. Please review and +1 if you can. Thanks. http://gerrit.cloudera.org:8080/#/c/6069/1//COMMIT_MSG Commit Message: PS1, Line 7: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. > In the commit message, have a blank line after this one. Otherwise it's tre Got the same comment from Jim. Stopped doing it this way. Not really a good use of time to redo for this. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS1, Line 1475: . : You can specify a single directory, or a comma-separated list of di > I would say just take out the whole phrase. Done http://gerrit.cloudera.org:8080/#/c/6069/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS2, Line 3665: "hidden"> > replace with 'hidden' -- There was a separate gerrit to replace all of thes Done http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_resources.xml File docs/topics/impala_perf_resources.xml: PS1, Line 78: such as cgroups > Question for MJ, whether the reference to cgroups is appropriate anymore at Did you add him to the review? I don't see it. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_testing.xml File docs/topics/impala_perf_testing.xml: PS1, Line 46: : > Watch out for trailing spaces or tabs on these new blank lines. I'm very careful about these. I insert a space and then a return to keep the chunks of text manageable. Don't think any change is necessary here. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: PS1, Line 505: On systems using cluster management software or those not using cluster management : software > That's a little bit convoluted phrasing. Let's find an SME on the dev team Just checked in with Alex B. to find an LZO setup guru on the Impala team. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale <lau...@cloudera.com> Gerrit-Reviewer: Ambreen Kazi <ambreen.k...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Laurel Hale <lau...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
