Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable ......................................................................
Patch Set 2: (2 comments) Yes, I did a private run with legacy join and agg before sending this out for review. Will do another run again before merging. http://gerrit.cloudera.org:8080/#/c/6263/1//COMMIT_MSG Commit Message: Line 16: > I looked and it seemed like the fallback would never be used since the GetC Didn't mean to rathole on this. Apparently, we didn't check for the return status of GetCodegendComputeFn() in that case. Anyhow, it seems nice to be able to interpret the child expression if codegen failed for it. http://gerrit.cloudera.org:8080/#/c/6263/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 1458: // Load &build_expr_ctxs_[0] > Stray comment. Done -- To view, visit http://gerrit.cloudera.org:8080/6263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
