Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode ......................................................................
Patch Set 3: (1 comment) haven't had a chance to look at most of the new code yet, but one quick comment before I run off to a few hours of meetings... http://gerrit.cloudera.org:8080/#/c/6312/3/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 21: #include <kudu/client/client.h> it would be really nice if we could avoid including the kudu header here. I think you may be able to forward declare KuduClient if you store std::unique_ptr in the map. I think that'd be better than keeping a shared_ptr anyway, since we return the naked ptrs and should avoid shared_ptrs wherever possible (plus it'll avoid leaking Kudu's 'shaded' sp::shared_ptr type). see http://howardhinnant.github.io/incomplete.html -- To view, visit http://gerrit.cloudera.org:8080/6312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e4593300e376bc508b78acaea64ffdd2c73a67a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
