Dan Hecht has posted comments on this change. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo ......................................................................
Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6402/5/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS5, Line 161: getcpu should that say sched_getcpu()? Line 186: LOG(FATAL) << "Could not find nodes in /sys/devices/system/node"; are we confident that all distros impala runs on will have this? why is this fatal, but !found_numa_node is not? why not be consistent? -- To view, visit http://gerrit.cloudera.org:8080/6402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
