Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ......................................................................
Patch Set 5: (6 comments) Thanks Henry! http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS5, Line 180: node can coordinate queries. > maybe tighten this up: Done http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 949: > comment? Done http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: PS5, Line 461: if (!FLAGS_disable_admission_control) { > again, it seems better to check to see if admission_controller() != nullptr Done http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/util/webserver.cc File be/src/util/webserver.cc: PS5, Line 192: FLAGS_is_coordinator > it would be neater to do something like: Done PS5, Line 192: Worker > nit: dunno how much we want to bikeshed this, but I prefer "Executor" to "W Renamed "worker" to "executor". Also, "coordinator" now is "coordinator + executor". http://gerrit.cloudera.org:8080/#/c/6344/5/www/root.tmpl File www/root.tmpl: Line 21: <h2>Impala Server Mode</h2> > This template gets used for catalog and statestored as well. You need to ch Good point, forgot about it. Fixed it. -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
