Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db ......................................................................
Patch Set 4: (2 comments) I also worked out another alternative - but then noticed the Open Group definition of mkstemp() has stronger guarantees that it will not select a duplicate filename if one already exists at the time of the call which is something a boost::filesystem::unique_file based solution can't provide. The Linux man page for mkstemp does not mention this behvaior. Posting anyway, but I'll revert and apply the WS and comment changes. http://pubs.opengroup.org/onlinepubs/009695399/functions/mkstemp.html http://gerrit.cloudera.org:8080/#/c/6503/4/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: PS4, Line 674: > remove one space Done PS4, Line 676: std > remove std:: Done -- To view, visit http://gerrit.cloudera.org:8080/6503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
