Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4166: Add SORT BY sql clause
......................................................................


Patch Set 3:

(1 comment)

Lars, a few high level questions before I start the next review iteration. 
Thanks

http://gerrit.cloudera.org:8080/#/c/6495/3//COMMIT_MSG
Commit Message:

PS3, Line 13: Specifying SORT BY columns also enables clustering during inserts,
            : so the SORT node will contain all partitioning columns first, 
followed
            : by the SORT BY columns.
Can you expand the comment a little bit on the semantics of this? A few high 
level questions are:
1. What is the connection between this and the sortby() hints? Can I use both? 
What if there is a conflict? Same for clustered hint.
2. Why does sort by enables clustering as well? 
3. Can I specify any table columns (even the partitioning columns) in the SORT 
BY clause or are there some restrictions? 
4. I suppose this works for all table types (including Kudu)?


-- 
To view, visit http://gerrit.cloudera.org:8080/6495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to