Dan Hecht has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6526/1/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: PS1, Line 180: Unix time (seconds since the Unix epoch) representation in UTC unix time isn't really "in UTC". It's just the number of seconds since unix epcoh (which is specified as Jan 1 1970 0:00 UTC). That is, unix time is timezone independent. The implied timezone (which in this case you want to be UTC) applies to the timestamp, not the resulting unix time. So, I think the comment should be something like: /// Interpret 'this' as a timestamp in UTC and convert to unix time. and rename the method accordingly. Or am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
