Alex Behm has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause ......................................................................
Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/6495/9/fe/src/main/java/org/apache/impala/analysis/TablePropertyAnalyzer.java File fe/src/main/java/org/apache/impala/analysis/TablePropertyAnalyzer.java: Line 85: public static List<Integer> analyzeSortByColumns(List<String> sortByCols, Do we need all the public APIs? Probably not a hug deal, but I worry about the N^2 loop in here. Table and KuduTable provide efficient ways for checking whether a column is a partition column or primary key. Line 114: if (!foundColumn) { Does this mean we need 2 ALTER statements to drop/rename a column? Line 115: throw new AnalysisException(String.format("Could not find SORT BY column '%s' " + Do we have a test for this? http://gerrit.cloudera.org:8080/#/c/6495/9/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: Line 458: public void setNumClusteringCols(int n) { numClusteringCols_ = n; } Preconditions.checkStats(RuntimeEnv.isTestEnv()); http://gerrit.cloudera.org:8080/#/c/6495/9/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: Line 170: # IMPALA-4166: sort by columns are correct when using a partial column permutation. What if neither bool_col or int_col are mentioned in the column permutation? Will we still create a sort node? -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
