Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6526/2/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 301: DCHECK(tv->UtcToUnixTimeMicros(&ts_micros)); > This seems to rely on a side effect but it would not execute in a release b good point, thanks http://gerrit.cloudera.org:8080/#/c/6526/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: Line 124: String colName = desc.getColumn().getName(); > Nit: move colName into the if block. Done http://gerrit.cloudera.org:8080/#/c/6526/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 1958: AnalyzesOk("create table tab (x timestamp, y timestamp, primary key(x, y)) " + > do we have a test where TS is not a PK and/or not a partition column? no I'll just adjust this one, I don't think both need to be PKs it's not really covering anything interesting -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
