Michael Brown has posted comments on this change. Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources. ......................................................................
Patch Set 2: (1 comment) Laurel, HTML and PDF look good, but see comment. http://gerrit.cloudera.org:8080/#/c/6604/2//COMMIT_MSG Commit Message: PS2, Line 7: IMPALA-4181 [DOCS] Publish rendered Impala : documentation to ASF resources. The commit header should only be 1 line. This is so commands like "git log --oneline" can identify commits easily and without clutter. That means the header shouldn't take up multiple lines or be too long. You're really close to a good commit message. What about something like this for the header? IMPALA-4181: [DOCS] Publish rendered Impala documentation to ASF site That way the header is 1 line, and short (notice it stays to the left of the orangey vertical dotted line when you view the commit message in Gerrit). The rest of the commit message is fine. -- To view, visit http://gerrit.cloudera.org:8080/6604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale <lau...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Laurel Hale <lau...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
