Dan Hecht has posted comments on this change. Change subject: IMPALA-5073: Part 1: add option to use mmap() for buffer pool ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/6474/9/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: PS9, Line 27: Impala will maybe delete that (to future proof in case this code is used in other applications). Line 96: // code if we are compiling against an older kernel. nit: the indentation got weird here http://gerrit.cloudera.org:8080/#/c/6474/9/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: Line 161: value_ = pool.peak_committed; why format this one differently? PS9, Line 174: allocated system-allocated, or was there a reason you didn't rename here too? -- To view, visit http://gerrit.cloudera.org:8080/6474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
