anujphadke has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6522/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 70: > We can make this more concise: Done Line 74: self.run_test_case('QueryTest/rows-read', vector) > Might as well make this a separate test method, e.g. test_rows_read(). Or a Done -- To view, visit http://gerrit.cloudera.org:8080/6522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie42c97a36e46172884cc497aa645036c2c11f541 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
