Tim Armstrong has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6627/1/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 288: if (exec_state->coord() != NULL) { > It's up for debate whether we want to add this or not. I added it to be con That's interesting, didn't realise that. My feeling is that it's best not to change this in this patchset. I'm not totally sure what the story is with HS2 - the thrift file says that GetLog() was removed in a Hive version. http://gerrit.cloudera.org:8080/#/c/6627/1/be/src/util/error-util.cc File be/src/util/error-util.cc: Line 123: const ArgType& arg4, const ArgType& arg5, const ArgType& arg6, const ArgType& arg7, > I spent some time looking at the different places that TStatus is used, and Looks good to me -- To view, visit http://gerrit.cloudera.org:8080/6627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d9d63610eb0d2acae3a9303ce46e1410727ce87 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
