Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6628/2/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 271: rapidjson::Document* document); > I can't find the forward declaration. How does this compile now? Is this in Exactly, it wasn't needed in the first place. http://gerrit.cloudera.org:8080/#/c/6628/2/be/src/util/webserver.cc File be/src/util/webserver.cc: Line 200: if (env->impala_server()->IsExecutor()) mode_str << " Executor"; > nit: this used to have a comma between them in the previous PS. The other p Done http://gerrit.cloudera.org:8080/#/c/6628/2/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: Line 69: 6: optional bool secure_webserver; > Maybe it'd be beneficial to add an optional flag "is_secured" to TNetworkAd Is this related to this change? Should I add a TODO instead? -- To view, visit http://gerrit.cloudera.org:8080/6628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d2ff7f341c9d2b0649e4d14561077e166ad7c4d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
