Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6651/2//COMMIT_MSG Commit Message: Line 17: (I) Improvement: METADATA-BENCHMARKS() > How do the numbers compare to pre-IMPALA-4172/IMPALA-3653? Is the regressio Tried triggering a perf build on pre-IMPALA-4172 branch. It doesn't work due to toolchain changes. With Mostafa's help I manually collected data from 2.9.0 release builds from Tableau, looks like there are no regressions. Last column corresponds to 2.9.0 release and the one before that corresponds to the master. (The tests probably changed a little, so might not be apples/apples comparison, but this is the best I could gather). 00:34:29.551 | METADATA-BENCHMARKS() | 100K-PARTITIONS-1M-FILES-10-REFRESH-AFTER-ADD-PARTITION | text / none / none | 220.59 | 232.525651932 00:34:29.551 | METADATA-BENCHMARKS() | 100K-PARTITIONS-1M-FILES-05-QUERY-AFTER-INV | text / none / none | 157.06 | 167.791799068 00:34:29.551 | METADATA-BENCHMARKS() | 100K-PARTITIONS-1M-FILES-11-DROP-PARTITION | text / none / none | 21.35 | 29.54668593 00:34:29.551 | METADATA-BENCHMARKS() | 100K-PARTITIONS-1M-FILES-03-RECOVER | text / none / none | 549.91 | 787.940558195 00:34:29.551 | METADATA-BENCHMARKS() | 100K-PARTITIONS-1M-FILES-09-INVALIDATE | text / none / none | 5.18 | 6.843062162 00:34:29.551 | METADATA-BENCHMARKS() | 100K-PARTITIONS-1M-FILES-08-ADD-PARTITION | text / none / none | 26.20 | 48.448208809 -- To view, visit http://gerrit.cloudera.org:8080/6651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f1f090518f317bcd7df069e480edbd8f039f1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes