Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: Line 207: current_membership_.insert(make_pair(item.key, be_desc)); > What else would we want to rename backend->executor besides backend_config_ There is a number of inner classes in this file (e.g. AddressableAssignment, BackendAssignmentInfo, etc) that use the term backend in fields and functions. I believe these should be renamed as well. I just want to make sure we agree on the scope of this change before I start modifying this file even more. -- To view, visit http://gerrit.cloudera.org:8080/6628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d2ff7f341c9d2b0649e4d14561077e166ad7c4d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
