Tim Armstrong has posted comments on this change. Change subject: IMPALA-5229: huge page-backed buffers with TCMalloc ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6687/2/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: Line 50: // Free() assumes that aggressive decommit is enabled for TCMalloc. > Hmm, seems strange the kernel doesn't break the huge page automatically whe It does seem a little strange but I'm not sure what all the heuristics are and how they interact. Yep that's what I'm saying. -- To view, visit http://gerrit.cloudera.org:8080/6687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84b46a46efed9aee6af41b5f10bf3f4b15889b8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
