Dan Hecht has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6626/7/be/src/common/init.cc File be/src/common/init.cc: PS7, Line 137: whenever : // consumption is checked is that true? consumption() doesn't refresh it -- I think only mem-tracker itself refreshes it, but outside callers won't. -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
