Michael Ho has posted comments on this change. Change subject: IMPALA-5031: remove undefined behavior: nullptr member function call ......................................................................
Patch Set 1: Code-Review+2 (1 comment) I suppose all current callers of this function are from code path with coordinator fragment and that's why we haven't hit any crash yet ? http://gerrit.cloudera.org:8080/#/c/6714/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS1, Line 379: coord_instance_ == nullptr) parenthesis is not needed. -- To view, visit http://gerrit.cloudera.org:8080/6714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
