Dan Hecht has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation ......................................................................
Patch Set 1: How about adding some explicit verifications of the types using that test uda that TIm had added here: https://gerrit.cloudera.org/#/c/5161/24/testdata/workloads/functional-query/queries/QueryTest/uda.test -- To view, visit http://gerrit.cloudera.org:8080/6724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I158303b20d1afdff23c67f3338b9c4af2ad80691 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: No
