Jim Apple has posted comments on this change.

Change subject: IMPALA-5245: fix ASAN buffer-allocator-test
......................................................................


Patch Set 1:

(1 comment)

Thanks for fixing this!

http://gerrit.cloudera.org:8080/#/c/6819/1/be/src/runtime/bufferpool/system-allocator.cc
File be/src/runtime/bufferpool/system-allocator.cc:

Line 124:   // Workaround ASAN bug where posix_memalign returns 0 even when 
allocation fails.
There are a couple of other places where posix_memalign is called, too. Can you 
fix those, too?


-- 
To view, visit http://gerrit.cloudera.org:8080/6819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f295f841b8b6e7996d54bdf2dfc0a092dcb864c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-HasComments: Yes

Reply via email to