Lars Volker has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS1, Line 688: > Can you talk about why you removed unique_database? When I look at QueryTes Good catch. I want to use the default databases for the scans, so that the test runs with functional and functional_text_gzip. Do you see a better option than splitting it up into two tests, one for the scans and one containing the DDLs? -- To view, visit http://gerrit.cloudera.org:8080/6817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes