Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ......................................................................
Patch Set 7: (2 comments) Thanks for the reviews. I'm going to squash in the "TimestampValue constructors refactoring" change [1] since that also has a +2 and it's related. 1: https://gerrit.cloudera.org/#/c/6510/11 http://gerrit.cloudera.org:8080/#/c/6526/7/be/src/exec/kudu-util.h File be/src/exec/kudu-util.h: Line 89: if (COPY_STRINGS) { > it doesn't feel like this particular if should be very performance-relevant Done http://gerrit.cloudera.org:8080/#/c/6526/7/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: Line 1: // Licensed to the Apache Software Foundation (ASF) under one > this file is included in bunch of .h files. now that you pulled out a bunch Good call -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
