Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6789/3/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: Line 206: toUnixTimeExpr.analyze(analyzer); you could also use a local analyzer (meaning new analyzer) here, no? that would save you a parameter. -- To view, visit http://gerrit.cloudera.org:8080/6789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b6c8354a408e7beb94c1a135c23722977246ea Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
