Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state ......................................................................
Patch Set 2: (1 comment) > Any good way to regression test this? Obviously its a timing issue when we'll advance query states, and without a good way to control the timing tests run the risk of either being flaky or being too permissive to catch bugs. One observation is with this change it will always be the case that after a call to ExecuteStatement (for hs2, or the equivalent for beeswax), the query will have advanced past CREATED to RUNNING or FINISHED (which was not the case before this patch) and after all rows have been fetched the state will be FINISHED. We could check for those things in tests, though I don't think they're required by the hs2 (or beeswax) spec so it may change in the future. http://gerrit.cloudera.org:8080/#/c/6923/2/be/src/service/client-request-state.h File be/src/service/client-request-state.h: PS2, Line 413: must ensure lock_ > Any chance we can DCHECK it ? >From looking through the boost documentation, I don't think so. -- To view, visit http://gerrit.cloudera.org:8080/6923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
