Alex Behm has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: Line 218: // comments[i][j] are the comments of tableNames[j] in dbs[i]. is the comment Line 291: comment = table.getMetaStoreTable().getParameters().get("comment"); Is there an HMS constant for this? http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: Line 184: Db testDb = addTestDb(dbName, "Stores tables with comments"); Should we fix this for DB comments as well? Or does that already work as expected? -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-HasComments: Yes
