Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6707/9/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 607: if (request_state->query_state() == beeswax::QueryState::CREATED) { as we discussed in person, here we'll return something like the caller does. Actually, maybe we should just return an error Status with the message, and then let the caller put that string in the profile? -- To view, visit http://gerrit.cloudera.org:8080/6707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44daa93e3ae4d04d091261f3ec4891caffe8026 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes