Alex Behm has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations ......................................................................
Patch Set 12: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6950/11/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 979: Status HdfsParquetScanner::ResetScratchBatch() { Looks like this is only called in a single place, so might as well move the two lines there and remove this function. http://gerrit.cloudera.org:8080/#/c/6950/11/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: Line 492: for (int i = 0; i < num_tuples; ++i) { int64_t i since num_tuples is an int64_t -- To view, visit http://gerrit.cloudera.org:8080/6950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49ec523a65542fdbabd53fbcc4a8901d769e5cd5 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
