Pooja Nilangekar has posted comments on this change. Change subject: IMPALA-5232: Parquet reader error message prints memory address instead of value ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6982/1//COMMIT_MSG Commit Message: Line 9: Changed the argument of the message to print the size instead of > We usually try to keep the commit message line lengths to 70 characters per Done Line 10: the memory location. > Can you mention how you tested it over here? Done http://gerrit.cloudera.org:8080/#/c/6982/2//COMMIT_MSG Commit Message: PS2, Line 8: > Nit: The title can exceed 70 chars. We want the title to be on one line so Done Line 16: value of num_bytes and performing a select on a table in parquet format. > It'll also be good to mention why you're not adding automated tests. Done -- To view, visit http://gerrit.cloudera.org:8080/6982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
