Henry Robinson has posted comments on this change. Change subject: IMPALA-5358: Fix repeatable table sample. ......................................................................
Patch Set 1: Ok, thanks - I think you mean that inputParts was arbitrarily ordered, so the bug was non-deterministic (but most of the time, gave the correct results in this case). That sounds fine, agree that we would expect current tests to find this. -- To view, visit http://gerrit.cloudera.org:8080/6985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9110751b075430b068b52d7441e5845f86d1b6af Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No