Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache ......................................................................
Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/6478/15/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 283: if (exclusive_hdfs_fh_ != nullptr) return Status::OK(); when will this be true? Line 351: VLOG_FILE << "Cache HDFS file handle file=" << file(); this is not a meaningful log message, let's remove it Line 420: HdfsFileHandle* hdfs_file_from_cache = nullptr; the name is somewhat misleading, because exclusive_hdfs_fh_ is still from the cache Line 484: // - or if the file handle is not from the cache but exclusive_hdfs_fh_ is also from the cache, why wouldn't we retry in that case (and reset exclusive_hdfs_fh_)? http://gerrit.cloudera.org:8080/#/c/6478/15/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: Line 1271: bool cache_hit; rename to dummy or something like that -- To view, visit http://gerrit.cloudera.org:8080/6478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5ff60971dd653c3b6a0e13928cfa9fc59d078d Gerrit-PatchSet: 15 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
