Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() ......................................................................
Patch Set 2: > Will wait for final patch before signing off. > > What was the reason behind moving ReleaseResources() out of Done()? > IIUC, the race is fixed by not releasing the QS reference until the > coordinator is destroyed. Leaving ReleaseResources() in Done() > seems natural, so I wondered what the thinking was. The thinking was that the coordinator already knows when it can release resources, and it seemed like a nice simplification of the public interface. -- To view, visit http://gerrit.cloudera.org:8080/6897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I457a6424a0255c137336c4bc01a6e7ed830d18c7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: No
