Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6935/5/be/src/benchmarks/free-lists-benchmark.cc File be/src/benchmarks/free-lists-benchmark.cc: Line 323: static SystemAllocator* allocator = nullptr; > what's the reason for this instead of static allocation? leave comment, so Undefined behavior due to undefined static initialization order in the SystemAllocator class. Will leave a comment. -- To view, visit http://gerrit.cloudera.org:8080/6935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e0ddfaa9bd1340990ae2b6ff946d72bbd26c274 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
