Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport ......................................................................
Patch Set 1: (1 comment) Thanks John. The internal connection timeout is actually 5 minutes: https://github.com/apache/incubator-impala/blob/master/be/src/runtime/exec-env.cc#L118-L123 We would also want the client connection timeout to default to a pretty high number since on large clusters, we've seen Kerberos negotiations take up to a few minutes. I would prefer keeping the timeout to 5 minutes. It's not ideal, however, we would rather not see queries fail because of timed out negotiations vs. optimize for an even worse case of clients hung for 5 minutes (which is configurable by a flag if the user chooses to do so). This is the same reason we keep the internal connection timeout so high, since we'd rather see progress than a failed query due to one timed out connection. http://gerrit.cloudera.org:8080/#/c/7061/1/be/src/transport/TSaslServerTransport.cpp File be/src/transport/TSaslServerTransport.cpp: PS1, Line 40: sasl_connect_tcp_timeout_seconds We usually keep our timeouts in milliseconds. it would be good to follow this example: https://github.com/apache/incubator-impala/blob/master/be/src/runtime/exec-env.cc#L118-L123 -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
