Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc()
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins-ir.cc
File be/src/exprs/udf-builtins-ir.cc:

PS1, Line 242: 
> May make sense to codegen and constant propagate in this case.
Yeah I agree it would be nice, I don't think we have the infrastructure now to 
do this in a generic way though, given the dispatch logic to map a string to an 
implementation is non-trivial. I didn't want to get sidetracked implementing a 
special-case optimisation here.


http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins.h
File be/src/exprs/udf-builtins.h:

PS1, Line 67: //
> nit:///
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I222258f51b2093a38929df847fdb5d25bb9aafc3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to