Dan Hecht has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: Line 184: // String taken from TSocket::write_partial() in Thrift's TSocket.cpp if we upgrade thrift, won't we need to recheck these? how will we remember to do that? Line 188: strstr(e.what(), "Socket send returned 0.") != nullptr); how do we know this last one is due to a dropped connection? also, for all of them, what happens if the receiver received some bytes before the connection was lost? how does restarting the rpc from the beginning work in that case? -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alan Choi <a...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
