Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7107/1/tests/comparison/cli_options.py File tests/comparison/cli_options.py: PS1, Line 146: '--cm-port', default=7180, type=int, metavar='port number', : help='The port of the CM server. Use 7183 with TLS enabled') I've never actually seen CM use non-standard ports, i.e. never something besides 7180/7183, and I used to work on CM. I wonder if we should bother with this flag or just set the port based on --use-tls. I'm saying this because it'd be nice we we didn't have to specify it. Perhaps fancier: it'd be nicer if this was only to specify non-std ports, so if you don't specify it then you get 7180/7183. -- To view, visit http://gerrit.cloudera.org:8080/7107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
