Dan Hecht has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for YYYY-M-D format ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 2216: TimestampValue::Parse("2001-01-21 00:00:00")); what about a single month or day but with a valid time? is that suppose to work or not? -- To view, visit http://gerrit.cloudera.org:8080/7009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-HasComments: Yes