Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5221: Avoid re-use of stale SASL contexts. ......................................................................
Patch Set 2: > > (11 comments) > > > > Looks pretty good. Have you confirmed this works with LDAP as > well > > as GSSAPI? > > Forgot to address the LDAP comment. I just got my hands on a > cluster with LDAP enabled, I'll test the patch on it and post an > update tomorrow. Verified that there are no regressions on a cluster with LDAP enabled too. - Deployed my patch onto an LDAP enabled cluster. - I was able to connect with a client using LDAP credentials. - Verified that I saw the following in the logs: I0609 09:31:49.210407 11809 authentication.cc:249] Trying simple LDAP bind for: uid=admin,ou=users,dc=cloudera,dc=com I0609 09:31:49.565165 11809 authentication.cc:261] LDAP bind successful I0609 09:31:49.565322 11809 authentication.cc:459] Successfully authenticated client user "admin" -- To view, visit http://gerrit.cloudera.org:8080/7116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d509e14dfe46fa28d0626cf84daf6de82955d80 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: No