Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7155
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState ...................................................................... IMPALA-5427: Fix order of status handling in ClientRequestState There was a race in ClientRequestState::UpdateQueryStatus() leading to the rare situation that a query would abort with an error, but the error message would be empty. The fix is to update the query_status_ before setting it to preserve the error message. To test this I ran test_corrupt_files in a loop for 2 days. Without this fix, it would usually fail within a few hours. I changed the test to allow running it in parallel like so: @pytest.mark.parametrize('multiplier', xrange(32)) def test_corrupt_files(self, vector, multiplier): Then I ran it in a loop like so: i=0; while [ $? -eq 0 ]; do ((++i)); echo "Run: $i"; impala-py.test tests/query_test/test_scanners.py::TestParquet::test_corrupt_files --exploration_strategy=exhaustive -n8; done Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 --- M be/src/service/client-request-state.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/7155/1 -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com>