Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates ......................................................................
Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/7168/6/fe/src/test/java/org/apache/impala/analysis/ExprSelectivityTest.java File fe/src/test/java/org/apache/impala/analysis/ExprSelectivityTest.java: Line 31: public void verifySelectivityStmt(String stmtStr, double expectedSel) > we indent 2 Done Line 33: SelectStmt stmt = (SelectStmt) ParsesOk(stmtStr); > simplify with AnalyzesOk() Done Line 38: assertEquals(calculatedSel,expectedSel); > space after comma Done Line 43: String stmtStr = "select * from functional.alltypes where id " + > simplify this to "select <predicate> from functional.alltypes" Done Line 52: private double getPredSel(int numPredChild) { > Very specific to IN predicate. How about we hardcode the expected values fo Done Line 69: verifySel("in (1,3,5,7)", getPredSel(4)); > Seems cleaner to provide the full expr as input and not assume "id". That w Done -- To view, visit http://gerrit.cloudera.org:8080/7168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e6217257b5618cb63e13b32ba3347fa0483b63 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-HasComments: Yes
