Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load ......................................................................
Patch Set 1: (1 comment) Alex, I did a quick audit of the exists() checks in HdfsTable and none of them seem to be duplicates/redundant. Could you confirm which ones you refer to in your last comment? Ofcourse we can cache that check per table/partition but I don't think we should do that and instead have a runtime check. http://gerrit.cloudera.org:8080/#/c/7095/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS1, Line 1486: FileSystem fs = partDirPath.getFileSystem(CONF); > remove Looking into it, actually StorageDescriptor is not at all needed, we are just passing it around without using it. I'll check its implications and remove it in a follow up patch. Raised IMPALA-5533 -- To view, visit http://gerrit.cloudera.org:8080/7095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
