Tim Armstrong has posted comments on this change. Change subject: IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7254/1/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 275: while (!output_iterator_.AtEnd()) { Should this be inside the if() statement? Since it references dummy_dst. -- To view, visit http://gerrit.cloudera.org:8080/7254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f8cce7cf6e3183d3a5e145c2fcfa50f36c77e0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes